|By Manuel Weiss||
|August 30, 2013 01:00 PM EDT||
This is a republished blog post. You can find the original source here: http://blog.codeship.io/2013/08/22/the-codeship-workflow-part-2-pull-requests-and-code-review.html
Using Pull Requests
As I mentioned last week we use GitHub Flow on GitHub. But the whole workflow we describe is also possible when working with BitBucket. We do not have a policy when a pull request should be opened. Some of our developers open them when they start a feature, some wait until the feature is implemented. Then we push regularly to that branch as explained in the last post.
Open pull requests are helpful as everyone can see what we are working on. One really important part of feature branches and pull requests are proper commit messages.
Writing good commit messages
As a distributed version control system, git makes it easy to take large changes and split them into small commits. Then these commits have a descriptive message with a short explanation in the first line and, if necessary, a longer description after a separation line. The git documentation project has some nice guidelines on it. Giving every commit a proper message and splitting large changes into a number of small commits makes your code history easier to read. It will be easier for your teammates to understand the history of your code.
I personally prefer git-gui for commiting and splitting up commits. It does only this job, but it does it very well. Take a look at some of the other git tools we like at the end of the post.
Using GitHub Issues and Labels
Once the feature is ready to be reviewed we assign its pull request to somebody else on the team. you have to read through the changes on GitHub at least once before handing the pull request . Making sure no obvious errors are in the code reduces the time and cycles necessary for a good code review. It is very helpful to inspect the changes outside of your own editor and with the excellent GitHub comparison view.
Now that we assigned the pull request, somebody on our team has a GitHub issue with his name attached. This way anybody can easily filter out the pull requests they need to look through. Now the last step is labeling the pull request with needs review. This way the reviewer knows this pull request is finally ready to reviewed.
When starting a pull request, the developer and reviewer can decide on looking through the pull request together or not. Especially for large changes reviewing the code as a pair is great.
Then we review the structure and syntax of the code, but we currently do not review the functionality itself. Before implementing a feature we discuss it in detail, so there is a common understanding. Once the feature is implemented, we trust our engineers that it does what it should. We are not working with a staging system.
One improvement we are starting with now is functional reviews for large and public facing features. Just so a second pair of eyes looks at changes that possibly impact a lot of our users. But this is still not a strict part of our workflow. A developer may request it after the implementation or we plan it before we start working on it.
When the review is done it either gets merged or, if the reviewer leaves comments, the GitHub issue is labeled as reviewed. This way developers can take a look at their open issues and see which have been reviewed and which need more attention.
The feature is ready to be merged as soon as the developer either updates the pull request or explains why she did it differently.
There's one challenge with every release workflow that involves code reviews: Getting the team to review as fast as possible without interrupting their work. We try to do it asynchronously for smaller features and sitting down for shared code review on larger features. This is no silver bullet, but in our experience it works well.
GitHub Merge Button
To make sure nobody introduces changes into our production system without review, we have a strict rule that you can never merge your own code. This rule is not enforced through technology, but a strict team policy.
The only exceptions are scheduled releases, for example a maintenance Deployment. Then we let somebody review the changes and leave a ready to be merged comment. The build can then be merged whenever the developer wants.
By releasing through the GitHub merge button everyone on the team can push to production. Making this possible for every developer or designer in our team is very valuable. It allows everyone to take part in the process and it speeds up our daily work.
As soon as we hit the merge button our tests are kicked off on the Codeship again and the deployment starts. Next time we will go into more detail about this part of our infrastructure, how we deploy to our staging app, test our migrations, build our deployment pipelines and then push to production several times a day.
Your Development Workflow
How are you working? We would love to hear about it in the comments. Let us know if you have any questions or suggestions to our workflow. Your feedback is always appreciated!
Ship long and prosper.
- Acquia Appoints Martyn Eley as General Manager of EMEA Operations
- U.S. General Services Administration Moves Order Management System to IBM SmartCloud for Government
- The DevOps Way to Solve JVM Memory Issues
- Cisco Web Security Webinar: Ensure World Class Protection
- SDN: Uncovering Amazon's Secret Sauce
- Mobilizing Business Data: The Holy Grail of Enterprise Mobility
- What Doesn't Kill You Makes You...Smarter
- On-Premise or Cloud ERP - Which Is Right for Your Business?
- Ten Questions to Avoid a Classical Business War Room Scenario
- What Business Leaders Want from IT Monitoring
- The Final IT Evolution – Cloud
- WebRTC Summit at Cloud Expo Agenda Announced
- OneLogin Raises $13M to Power Expansion
- Gartner Hype Cycle 2012 – Emerging Technologies
- Five Technology Trends That Require Scrutiny
- Nine Stunning 3D Printed Objects
- User Accounts Are Only the Tip of the Iceberg
- The Zacks Analyst Blog Highlights: Ford Motor, Microsoft, Volkswagen, General Motors, Autodesk, Apple, Google and Adobe Systems
- Fathers of Clouds – A Tribute
- Acquia Appoints Martyn Eley as General Manager of EMEA Operations
- Open Server Summit Reports Doubling of Registration
- Drupal 8: A View into Performance
- The Top 150 Players in Cloud Computing
- Who Are The All-Time Heroes of i-Technology?
- Where Are RIA Technologies Headed in 2008?
- Success, Arrogance, Rise and Fall
- AJAX World RIA Conference & Expo Kicks Off in New York City
- The Top 250 Players in the Cloud Computing Ecosystem
- Personal Branding Checklist
- i-Technology Viewpoint: Attack of the Blogs
- Exclusive Q&A with Jeff Haynie, Co-Founder & CEO, Appcelerator
- Web 2.0 News and Wrapping Up "Real-World AJAX" Seminar
- Passing Parameters to Flex That Works
- Cloud People: A Who's Who of Cloud Computing